Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Fix order of Kubernetes versions in Compatibility matrix #2548

Merged
merged 1 commit into from
Oct 19, 2020

Conversation

rohanKanojia
Copy link
Member

  • latest Kubernetes Versions should be shown first followed by older versions
  • Added column for 1.16.0 as discussed in Support for kubernetes 1.16 #2509
  • Added column for OpenShift 4.5.14(after running integration tests on crc)

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change
  • Chore (non-breaking change which doesn't affect codebase;
    test, version modification, documentation, etc.)

Checklist

  • Code contributed by me aligns with current project license: Apache 2.0
  • I Added CHANGELOG entry regarding this change
  • I have implemented unit tests to cover my changes
  • I have added/updated the javadocs and other documentation accordingly
  • No new bugs, code smells, etc. in SonarCloud report
  • I tested my code in Kubernetes
  • I tested my code in OpenShift

@manusa
Copy link
Member

manusa commented Oct 19, 2020

image

This looks awkard. I think it will raise more questions rather than helping.

+ latest Kubernetes Versions should be shown first followed by older versions
+ Added column for 1.16.0 as discussed in fabric8io#2509
+ Added column for OpenShift 4.5.14(after running integration tests on `crc`)
@rohanKanojia
Copy link
Member Author

Thanks for noticing, looks like I missed it 👀

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

warning The version of Java (1.8.0_265) you have used to run this analysis is deprecated and we will stop accepting it from October 2020. Please update to at least Java 11.
Read more here

@manusa
Copy link
Member

manusa commented Oct 19, 2020

[merge]

@fusesource-ci fusesource-ci merged commit f1b0511 into fabric8io:master Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants