Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for kubernetes 1.16 #2509

Closed
rktechie opened this issue Sep 25, 2020 · 8 comments
Closed

Support for kubernetes 1.16 #2509

rktechie opened this issue Sep 25, 2020 · 8 comments
Assignees
Milestone

Comments

@rktechie
Copy link

I see in the documentation that kubernetes 1.15.3 and 1.17.0, which of the clients support kubernetes 1.16?

@Aitozi
Copy link

Aitozi commented Sep 28, 2020

BTW,another question: Is version 4.1.0 support Kubernetes 1.16?

@rohanKanojia
Copy link
Member

We updated the Kubernetes Model to Kubernetes 1.17.x in v4.7.0. In our compatibility matrix, when we say the client supports 1.17.x, we mean it supports up to Kubernetes 1.17.x(unless there is some breaking change in between Kubernetes 1.16.x and 1.17.x).

Could you please try with versions after 4.7.0 for your setup and see if they work fine? Are you looking for something in particular related to Kubernetes 1.16.x that we might be missing?

@manusa
Copy link
Member

manusa commented Oct 5, 2020

It's probably safe to assume that Kubernetes Client works with 1.16.x

  • We should check from which Kuberentes-Client version we are 1.16.x compliant
  • We should also use this issue to reverse the compatibility matrices so that newest/more recent versions come left-most and top-most

@rohanKanojia
Copy link
Member

I just checked compatibility with 1.16 by running our integration test suite on my branch with minikube's version set to 1.16.0: https://github.com/rohanKanojia/kubernetes-client/runs/1241248067?check_suite_focus=true

@manusa
Copy link
Member

manusa commented Oct 13, 2020

That's good, but we need to check from which Kubernetes Client Version we are 1.16 compliant. According to the current compatibility matrix, this should be between 4.6.0 and 4.7.0.

If we don't want to do any extra tests (probably not worth it), we should settle on 4.7.0.

@rohanKanojia rohanKanojia self-assigned this Oct 15, 2020
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Oct 15, 2020
+ latest Kubernetes Versions should be shown first followed by older versions
+ Added column for 1.16.0 as discussed in fabric8io#2509
+ Added column for OpenShift 4.5.14(after running integration tests on `crc`)
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Oct 15, 2020
+ latest Kubernetes Versions should be shown first followed by older versions
+ Added column for 1.16.0 as discussed in fabric8io#2509
+ Added column for OpenShift 4.5.14(after running integration tests on `crc`)
rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Oct 15, 2020
+ latest Kubernetes Versions should be shown first followed by older versions
+ Added column for 1.16.0 as discussed in fabric8io#2509
+ Added column for OpenShift 4.5.14(after running integration tests on `crc`)
@rohanKanojia
Copy link
Member

@Aitozi @rktechie: I've created a PR for adding Kubernetes 1.16.0 to the compatibility matrix. I would suggest using Kubernetes Client 4.7.0 and above. Could you please try it out and provide feedback?

rohanKanojia added a commit to rohanKanojia/kubernetes-client that referenced this issue Oct 19, 2020
+ latest Kubernetes Versions should be shown first followed by older versions
+ Added column for 1.16.0 as discussed in fabric8io#2509
+ Added column for OpenShift 4.5.14(after running integration tests on `crc`)
@rohanKanojia
Copy link
Member

polite ping, Did anyone get any chance to try KubernetesClient v4.7.0 on Kubernetes 1.16.x?

@rohanKanojia
Copy link
Member

Closing this as I think it's resolved. Please feel free to reopen in case you're still facing problems with this.

@manusa manusa added this to the 4.13.0 milestone Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants