Tekton OperationsImpl Scope Fix #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…de proper scoping (namespaced vs cluster-wide) for all parts using the rewritten go generator. Changes: - go configuration requires scoping definition for all CRDs - marker interface 'Namespaced' added - go generator adds the marker interface to all Namespaced CRDs - during the generation of the *OperationsImpl, the marker interface is used to detect the proper scoping. This fixes fabric8io#2193
|
Can one of the admins verify this patch? |
|
Kudos, SonarCloud Quality Gate passed!
|
|
ok to test |
rohanKanojia
approved these changes
May 6, 2020
|
@Fabian-K : Bdw, I've started to document client operations in our cheat sheet. Would appreciate if you could contribute some documentation regarding tekton extensions there 🙏 |
|
I just rebased my knative pr on top of this one and included the scoping info there as well. (although there are no cluster-scoped CRDs in knative) When other modules like ServiceCatalog or K8s core uses the generator rewrite, they are forced to include it by the go compiler :) The cheat sheet looks nice! Will try to find some time for tekton :) |
manusa
approved these changes
May 6, 2020
oscerd
approved these changes
May 7, 2020
|
[merge] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the generation logic for *OperationsImpl to include proper scoping (namespaced vs cluster-wide) for all parts using the rewritten go generator.
Changes:
This fixes #2193