Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tekton: ClusterTaskOperationsImpl has wrong scope #2193

Closed
Fabian-K opened this issue May 5, 2020 · 0 comments · Fixed by #2194
Closed

Tekton: ClusterTaskOperationsImpl has wrong scope #2193

Fabian-K opened this issue May 5, 2020 · 0 comments · Fixed by #2194
Labels
bug

Comments

@Fabian-K
Copy link
Contributor

Fabian-K commented May 5, 2020

Any operation involving the ClusterTaskOperationsImpl probably fails due to wrong scoping (namespaced instead of cluster-wide). This was discovered together with #2189. I´ll shortly propose a PR for this.
Fabian-K added a commit to Fabian-K/kubernetes-client that referenced this issue May 5, 2020
@Fabian-K
This commit updates the generation logic for *OperationsImpl to inclu…
d9376eb 
…de proper scoping (namespaced vs cluster-wide) for all parts using the rewritten go generator.

Changes:
- go configuration requires scoping definition for all CRDs
- marker interface 'Namespaced' added
- go generator adds the marker interface to all Namespaced CRDs
- during the generation of the *OperationsImpl, the marker interface is used to detect the proper scoping.

This fixes fabric8io#2193
@Fabian-K Fabian-K mentioned this issue May 5, 2020
Merged
@manusa manusa added the bug label May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Tekton OperationsImpl Scope Fix Fabian-K/kubernetes-client
2 participants
@manusa @Fabian-K