various fixes for 030-iob18 #2072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Hans Baier <hansfbaier@gmail.com>
Signed-off-by: Hans Baier <hansfbaier@gmail.com>
|
One of the results of these fixes is the discovery of two new features: |
…duces specimens to 40 Signed-off-by: Hans Baier <hansfbaier@gmail.com>
hansfbaier
force-pushed
the
various-fixes
branch
from
cf8b6c6
to
8ce3922
Compare
hansfbaier
changed the title
|
@tmichalak Ready for review. The Vref changes get rid of a lot of warning of mismatching Vref, but don't change the outcome. The IBUF_LOW_PWR_SUPPORTED change finds a new feature. |
tmichalak
requested changes
Dec 16, 2022
There was a problem hiding this comment.
I guess that the fact that this fuzzer is kintex specific could make up for some hacks that were used. However, we should not lose track of those and at least open an issue. The write_io_banks.tcl could use some generalization when it comes to the high performance banks. However, I like the fact that now only 40 specimens are enough and most of all that it works on hardware. Good work!!!
…e banks Signed-off-by: Hans Baier <hansfbaier@gmail.com>
|
@tmichalak I created the issue: #2073 |
Signed-off-by: Hans Baier <hansfbaier@gmail.com>
tmichalak
approved these changes
Dec 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Hans Baier hansfbaier@gmail.com