Fix EZP-28750: Draft preview displays wrong Version information #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrerom
reviewed
Jan 17, 2018
| {foreach $object.versions as $version} | ||
| {if eq($version.version, $object.published_version)} | ||
| {$version.creator.name|wash} | ||
| {foreach $object.versions as $tmp_version} |
There was a problem hiding this comment.
nitpick, but could also be for instance $object_version
There was a problem hiding this comment.
There is a variable named $object_version used in a few places, so I would need to check if it doesn't cause a similar issue.
adamwojs
approved these changes
Jan 18, 2018
emodric
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Excerpt from JIRA:
The issue was introduced in #1296.
It turns out that
$versionvariable is used by other templates and it shouldn't be changed, so I renamed it to something more temporary.