FIX EZP-27306: Display modifier of published version in edit view and in version view #1296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacek-foremski
force-pushed
the
EZP-27306_edit_view_modifier
branch
from
74e89b7 to
d21471d
Compare
andrerom
approved these changes
May 4, 2017
bdunogier
approved these changes
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an object info shows incorrect "modifier" name (displaying the modifier of the latest version instead, which is a draft created by modifying an object, which means that modifier name always shows the name of the current user).
This bug was introduced by this PR: #1114.
To make it work in edit view and version view, I suggest using published version instead of the latest version to retrieve the name of modifier. It seems logical modifier to me in both situations. We can't use the latest version, because of the reason mentioned above. We also can't use "object.current", because it introduces bug EZP-23672.
I used "foreach" to retrieve published version because I couldn't find any shortcut.