EZP-28950 Correct legacy instructions, site.ini is the best place for DB charset #2337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
Seems that for legacy to fully work, we have to add |
|
I'd say that db charset and app charset are two separate things (not recommended of course, but it could happen a lot in far-east countries). So keep separate settings in i18n and Database confi8g. |
|
@gggeek We have to keep separate config anyway, because config from |
|
PR on legacy at ezsystems/ezpublish-legacy#1361 |
|
@gggeek Yes, we'll keep the settings separate for sure. This PR is just about fixing upgrade instructions. |
andrerom
approved these changes
May 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The original PR #2277 had this change in i18n.ini, for reasons unknown/forgotten. It should work fine according to docs, and no problem was found in testing. But @emodric reported failures due to the mysql
utf8mb4charset being expected in ini-files and templates. As he pointed out, site.ini is the right/best place for the DB charset, since you may want to have different charset in db and elsewhere.Refs:
https://github.com/ezsystems/ezpublish-legacy/blob/master/settings/site.ini#L82
https://github.com/ezsystems/ezpublish-legacy/blob/master/settings/i18n.ini#L23
https://doc.ez.no/eZ-Publish/Technical-manual/4.x/Reference/Configuration-files/site.ini/DatabaseSettings/Charset
https://doc.ez.no/eZ-Publish/Technical-manual/4.x/Reference/Configuration-files/i18n.ini/CharacterSettings/Charset