-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EZP-28950: Add support for utf8mb4 charset to i18n #1361
Conversation
Note: This is a prerequisite for |
+1 |
For reference, before this PR, legacy doesn't know what
After the fix, this returns
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified with sanities.
Due to utf8mb4 changes, only ezsystems/ezpublish-legacy version compatible is 2018.06, to be released soon. All other versions will fail with the error described in ezsystems/ezpublish-legacy#1361
Due to utf8mb4 changes, only ezsystems/ezpublish-legacy version compatible is 2018.06, to be released soon. All other versions will fail with the error described in ezsystems/ezpublish-legacy#1361
eZ legacy does not recognize
utf8mb4
charset, instead falling back to conversion to a single byte charset set byeZTextCodec
, which results in the following beautiful error messages:The effect of this PR is that
utf8mb4
is internally recognized asutf-8
, resulting in no conversion from UTF8 taking place when used for example by the database layer.Disclaimer: I'm not claiming that this is a proper fix, especially in this obscure part of legacy, but it seems logical :)
@glye @andrerom @gggeek @alongosz Any input on your side?