Skip to content
This repository has been archived by the owner on Apr 7, 2023. It is now read-only.

[android] Build only the app artifact and not all available libraries #214

Merged
merged 2 commits into from
Apr 21, 2020

Conversation

sjchmiela
Copy link
Contributor

Checklist

  • I've read the Contribution Guidelines.
  • I've updated the CHANGELOG if necessary.
  • I've ensured the unit and smoke tests are still passing - either by running yarn test:unit and yarn test:smoke:[ios|android] or by checking the appropriate CircleCI builds' statuses.
  • I've manually tested whether the changes I made work as expected.

Motivation and Context

I have noticed that not only the app project is being built on Turtle, but all the projects. (cross-posting from expo/expo-cli#1937)

Description

I've scoped the Gradle command to only build/assemble the :app project. It should be safe to do for all SDKs, since on all SDKs the app project was called app.

Published an alpha version of XDL to NPM, upgraded Turtle to it, deployed to staging and ran the build. It was over a minute faster than without this change (new vs old). (cross-posting from expo/expo-cli#1937)

@sjchmiela sjchmiela requested a review from dsokal April 21, 2020 09:10
Copy link
Contributor

@dsokal dsokal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@sjchmiela sjchmiela merged commit 72744f5 into master Apr 21, 2020
@sjchmiela sjchmiela deleted the @sjchmiela/build-only-app branch April 21, 2020 09:11
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants