This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[xdl] Assemble/bundle only the :app project #1937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjchmiela
force-pushed
the
@sjchmiela/build-only-app
branch
from
165a615
to
ab6c045
Compare
Codecov Report
@@ Coverage Diff @@
## master #1937 +/- ##
=======================================
Coverage 62.73% 62.73%
=======================================
Files 83 83
Lines 2517 2517
Branches 690 690
=======================================
Hits 1579 1579
Misses 915 915
Partials 23 23 Continue to review full report at Codecov.
|
dsokal
approved these changes
Apr 21, 2020
4 tasks
sjchmiela
added a commit
to expo/turtle
that referenced
this pull request
Apr 21, 2020
…#214) ### Motivation and Context I have noticed that not only the `app` project is being built on Turtle, but all the projects. (cross-posting from expo/expo-cli#1937) ### Description I've scoped the Gradle command to only build/assemble the `:app` project. It should be safe to do for all SDKs, since on all SDKs the app project was called `app`. Published an alpha version of XDL to NPM, upgraded Turtle to it, deployed to staging and ran the build. It was over a minute faster than without this change ([new](https://staging.expo.io/dashboard/sjchmiela/builds/5c386cef-e808-49d3-91d8-9ce42af77c36) vs [old](https://staging.expo.io/dashboard/sjchmiela/builds/3d36340e-6ae1-4476-91cb-07d81f1edd1e)). (cross-posting from expo/expo-cli#1937)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I have noticed that not only the
appproject is being built on Turtle, but all the projects.How
I've scoped the Gradle command to only build/assemble the
:appproject. It should be safe to do for all SDKs, since on all SDKs the app project was calledapp.Test plan
Published an alpha version of XDL to NPM, upgraded Turtle to it, deployed to staging and ran the build. It was over a minute faster than without this change (new vs old).