Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[config] config plugins iOS #2789

Merged
merged 51 commits into from
Nov 3, 2020
Merged

[config] config plugins iOS #2789

merged 51 commits into from
Nov 3, 2020

Conversation

EvanBacon
Copy link
Contributor

@EvanBacon EvanBacon commented Oct 14, 2020 •
edited
Loading

Further work

After merging, I'll create @expo/config-plugins and fix the imports across expo-cli and expo/config.

@EvanBacon
Added plugins to the config object
e001fcb
@EvanBacon
Implemented plugins config object
8bd2d82
@EvanBacon
Update IosPlist.ts
1b5a192
@EvanBacon
added basic plugins compiler for iOS
7380d52
@EvanBacon
Implement basic iOS plugins
c114610
@EvanBacon
simplify plugin creation
d263315
@EvanBacon
Update ios-plugins.ts
87118b3
@EvanBacon
tighten APi
5085c71
@EvanBacon
Update core-plugins.ts
4952870
@EvanBacon
Update Config.types.ts
19e83c6
@EvanBacon
[wip] plugin compiler
b873e3e
@EvanBacon
migrate to data providers system
efa433a
@EvanBacon
wip rename types
dfdbb7f
@EvanBacon
assert invalid modifier results
0d4ccaf
@EvanBacon
reintegrate plugins
f7fcb82
@EvanBacon
Update IosPlist.ts
23cac3e
@EvanBacon
Update plugin-compiler.ts
34ce28d
@EvanBacon
move to single object type
79692d5
@EvanBacon
Merge branch 'master' into @evanbacon/config/plugins-config
e8ff60a
@EvanBacon
Update configureIOSProjectAsync.ts
62bbe49
@EvanBacon
run entitlements after xcode
d6e2421
@EvanBacon
Move entitlements file, and clean up others
f141387
@EvanBacon
keep config objects in sync
7ef1b85
@EvanBacon
added basic e2e tests for compiling all plugins
bc6b8d0
@EvanBacon
revert unintended changes
f8ffa18
@EvanBacon
simplify types
9aaef1e
@EvanBacon
Split up plugin types
9227b17
@EvanBacon
Merge branch 'master' into @evanbacon/config/plugins-config
5cc599e
@EvanBacon
use plist
c7bdb16
@EvanBacon
plugins -> modifiers
a983418
@EvanBacon EvanBacon mentioned this pull request Oct 19, 2020
Merged
@EvanBacon EvanBacon mentioned this pull request Oct 19, 2020
Closed
@EvanBacon EvanBacon marked this pull request as ready for review October 19, 2020 16:26
@EvanBacon EvanBacon requested review from brentvatne and fson October 19, 2020 16:26
brentvatne
brentvatne approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@brentvatne brentvatne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments on slack. nice work

packages/config/src/plugins/expo-plugins.ts Show resolved Hide resolved
@EvanBacon EvanBacon merged commit 2592b70 into master Nov 3, 2020
@EvanBacon EvanBacon deleted the @evanbacon/config/plugins-config branch November 3, 2020 13:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@brentvatne brentvatne brentvatne approved these changes

@fson fson Awaiting requested review from fson

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EvanBacon @brentvatne