This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When syncing projects there are going to be certain cases that cannot be abstracted completely, for these cases we'll need a way to pipe raw data through an interface that plugins can modify.
For instance, say a plugin needed to add a new activity to the
AndroidManifest.xml
, in this case it can use the new config to modify the JSON directly.We'd still encourage that most props use the expo abstracted fields like
android.metadata
orios.infoPlist
.How
Created a new config namespace that doesn't get serialized at evaluation:
Internally we extend this system for our built in third-party plugins like Facebook, Branch, Google Maps, etc. In user's
app.config.js
, they could utilize the same composition pattern:Considerations
pack
is just a placeholder namespace.android.manifest() {}
that only gets used for building and stripped from the public manifest.{ expo: {}, pack({ files }) { return {files} } }
Test Plan