This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
[configure-splash-screen]<feat>: Accommodate Android singletons.SplashScreen import from the subpackage #2699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbarthec
force-pushed
the
@bbarthec/configure-splash-screen/adjust-singletons-import
branch
from
8f9cf1b
to
cbbca5d
Compare
expo/expo#10294 introduces scoping to SplashScreen object used in project's MainActivity
bbarthec
force-pushed
the
@bbarthec/configure-splash-screen/adjust-singletons-import
branch
from
cbbca5d
to
4bbc065
Compare
bbarthec
deleted the
@bbarthec/configure-splash-screen/adjust-singletons-import
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
don't merge before #2698
Follow up of #2698
Follow up of expo/expo#10294
This is supplementary change that accommodates Android API change from expo/expo#10294
TODOs after merge:
@expo/configure-splash-screenexpo-splash-screenpackage onexpo/expo#sdk-39branch and publish with patch version for0.6.xexpo-splash-screenpackage onexpo/expo#masterbranch and publish with patch version for0.7.x@next