Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

[configure-splash-screen]<feat>: Make Android configuration conform to the new native API #2698

Merged

Conversation

bbarthec
Copy link
Contributor

@bbarthec bbarthec commented Sep 24, 2020

Recent change in expo-splash-screen expo/expo@2770008#diff-70eefa11c7e96de30d02e5d069488fe2R35-R40
changed the native Android API.

This PR accommodates this native API change.

Resolves #2586

All published versions since expo/expo@2196ceb needs this adjustment:

  • 0.6.x
  • 0.7.x@next

TODOs after merge:

  • publish new version of @expo/configure-splash-screen
  • bump dependency version in expo-splash-screen package on expo/expo#sdk-39 branch and publish with patch version for 0.6.x
  • bump dependency version in expo-splash-screen package on expo/expo#master branch and publish with patch version for 0.7.x@next

Copy link
Contributor

@sjchmiela sjchmiela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic seems a bit too magicy to me (especially the fact that the first .applyAction could be replaced by if (content.includes() in the would-be-only second action), but as I understand it the results should be correct and as I'm not a major contributor to expo-cli I won't argue to change this. 👍

@bbarthec
Copy link
Contributor Author

@expo/configure-splash-screen is not designed to be backward compatible and there are at least two risky scenarios that might not be working fully:

  • when the user was using the previous version of this command, upgraded and want to run this command again - I've tried to generalise RegExps to cover it though
  • this command would not be working with @expo/config if the targeted project is not using expo-splash-screen@0.{6,7}.x package - solution for this is to tell the people to upgrade to the newest expo-splash-screen version

@bbarthec bbarthec merged commit 68c99db into master Sep 28, 2020
@bbarthec bbarthec deleted the @bbarthec/configure-splash-screen/adjust-main-activity branch September 28, 2020 12:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[configure-splash-screen] Incorrect call for SplashScreen.show in MainActivity
2 participants