Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

@sviande/adb kill #2064

Merged
merged 2 commits into from
Jul 24, 2020
Merged

@sviande/adb kill #2064

merged 2 commits into from
Jul 24, 2020

Conversation

sviande
Copy link
Contributor

@sviande sviande commented May 4, 2020

Stop ADB daemon only when expo launched it.

Fix a behavior introduce by #1876 it kills ADB daemon even if another process uses it.

Test 1

#ADB is not running
expo start
#ctrl-c expo
#adb is not running

Test 2

adb start-server
#use ADB (adb push, scrcpy....)
expo start
#ctrl-c expo
#ADB is always running

@brentvatne brentvatne requested a review from byCedric May 5, 2020 20:46
@brentvatne
Copy link
Member

@byCedric - what do you think?

@byCedric
Copy link
Member

byCedric commented May 6, 2020

Looks good! It's a similar approach to our publish command. I didn't think it would matter a lot, because once you run a new ADB command it will start up the daemon again.

@brentvatne brentvatne merged commit 398af44 into expo:master Jul 24, 2020
@sviande sviande deleted the @sviande/adb-kill branch July 25, 2020 16:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants