This repository has been archived by the owner on Jan 18, 2024. It is now read-only.
fix(xdl): try to stop adb when shutting down #1876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think either prettier or eslint is responsible for the parentheses changes 😅 |
brentvatne
approved these changes
Apr 14, 2020
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #283, #175
This PR requires a fix for the graceful shutdown on Windows, see #1749.
What did I do
Android.maybeStopAdbDaemonAsyncin the XDLAndroid.maybeStopAdbDaemonAsyncinProject._stopInternalAsyncWhy did I do
If you install the CLI locally you have the shipped ADB binaries in your project's
node_modules. On Windows keeping the daemon running results in a "blocking" node modules folder, you can't remove the file while the process is running.How does this do for others
The impact should be minimal. Even if the developer is using a custom installed ADB, the daemon is restarted automagically by ADB when executing commands 😄