[xdl] Fix test failure and add a note about ignored param

expo · Jul 15, 2020 · 9ae9772 · brentvatne · Jul 15, 2020 · 9ae9772
1 parent 81cb78b
commit 9ae9772
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 0 deletions.
diff --git a/packages/xdl/src/Project.ts b/packages/xdl/src/Project.ts
@@ -2030,6 +2030,7 @@ function getManifestHandler(projectRoot: string) {
 
 export async function getSignedManifestStringAsync(
   manifest: ExpoConfig,
+  // NOTE: we currently ignore the currentSession that is passed in, see the note below about analytics.
   currentSession: { sessionSecret: string }
 ) {
   const manifestString = JSON.stringify(manifest);

diff --git a/packages/xdl/src/__tests__/Project-test.ts b/packages/xdl/src/__tests__/Project-test.ts
@@ -5,6 +5,12 @@ import { getSignedManifestStringAsync, getUnsignedManifestString } from '../Proj
 
 jest.mock('axios');
 
+jest.mock('../User', () => ({
+  ensureLoggedInAsync: () => ({
+    sessionSecret: 'SECRET',
+  }),
+}));
+
 const mockManifest: ExpoConfig = {
   name: 'Hello',
   slug: 'hello-world',