Skip to content
This repository has been archived by the owner on Jan 18, 2024. It is now read-only.

Commit

Permalink
[xdl] fix analytics for expo start (#2357)
Browse files Browse the repository at this point in the history
  • Loading branch information
esamelson authored Jul 15, 2020
1 parent b600ab2 commit 81cb78b
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion packages/xdl/src/Project.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2036,7 +2036,10 @@ export async function getSignedManifestStringAsync(
if (_cachedSignedManifest.manifestString === manifestString) {
return _cachedSignedManifest.signedManifest;
}
const { response } = await ApiV2.clientForUser(currentSession).postAsync('manifest/sign', {
// WARNING: Removing the following line will regress analytics, see: https://github.com/expo/expo-cli/pull/2357
// TODO: make this more obvious from code
const user = await UserManager.ensureLoggedInAsync();
const { response } = await ApiV2.clientForUser(user).postAsync('manifest/sign', {
args: {
remoteUsername: manifest.owner ?? (await UserManager.getCurrentUsernameAsync()),
remotePackageName: manifest.slug,
Expand Down

0 comments on commit 81cb78b

Please sign in to comment.