add polynomial kernel #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dlinzner-bcs
commented
Oct 5, 2023
•
dlinzner-bcs
commented
- added support for polynomial kernels
- add QuadraticSurrogate that performs Bayesian quadratic regression
added 8 commits
October 5, 2023 13:37
bertiqwerty
approved these changes
Oct 6, 2023
| from bofire.data_models.surrogates.trainable import TrainableSurrogate | ||
|
|
||
|
|
||
| class QuadraticSurrogate(BotorchSurrogate, TrainableSurrogate): |
There was a problem hiding this comment.
Rather PolynomialSurrogate?
There was a problem hiding this comment.
This specific one has power=2. So its quadratic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.