Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove test_ prefix from tests #1727

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Remove test_ prefix from tests #1727

merged 1 commit into from
Sep 14, 2023

Conversation

senekor
Copy link
Contributor

@senekor senekor commented Sep 11, 2023

[no important files changed]

closes #1720

Base automatically changed from unimpl-todo to main September 14, 2023 06:35
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding [no important files changed] to the commit body.

@senekor senekor merged commit 62d7480 into main Sep 14, 2023
11 checks passed
@senekor senekor deleted the no-test-prefix branch September 14, 2023 10:17
@ErikSchierboom
Copy link
Member

@senekor Looking at 62d7480, it looks like the [no important files changed] marker is missing from the commit :( This means that we'll have a huge number of solutions being processed.

@senekor
Copy link
Contributor Author

senekor commented Sep 14, 2023

Oh noooo 😨 how did I screw that up 😭

@senekor
Copy link
Contributor Author

senekor commented Sep 14, 2023

It looks like I had the line in the PR description, but not in the commit message body. I presume when there is only one commit, this repo is setup to pick the body of the single commit, not the PR description. I'm used to the latter, but should've double checked...

@ErikSchierboom
Copy link
Member

Well, lesson learned I guess! It's easy to make this mistake.

@MatthijsBlom
Copy link

It's easy to make this mistake.

I proposed to make [no important files changed] the default a while ago. This same mistake is going to be made again many, many times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove test_ prefix from test functions
3 participants