-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove test_ prefix from tests #1727
Conversation
7949362
to
dde865a
Compare
a4d3b6b
to
883e45d
Compare
dde865a
to
2210a2d
Compare
883e45d
to
c4a2c76
Compare
2210a2d
to
bd1e01c
Compare
c4a2c76
to
321824b
Compare
bd1e01c
to
654a972
Compare
321824b
to
08ee069
Compare
654a972
to
d94f686
Compare
08ee069
to
655c176
Compare
d94f686
to
6d4fa9f
Compare
655c176
to
4696194
Compare
4696194
to
8f44f00
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding [no important files changed]
to the commit body.
Oh noooo 😨 how did I screw that up 😭 |
It looks like I had the line in the PR description, but not in the commit message body. I presume when there is only one commit, this repo is setup to pick the body of the single commit, not the PR description. I'm used to the latter, but should've double checked... |
Well, lesson learned I guess! It's easy to make this mistake. |
I proposed to make |
[no important files changed]
closes #1720