Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove test_ prefix from test functions #1720

Closed
senekor opened this issue Sep 9, 2023 · 1 comment · Fixed by #1727
Closed

Remove test_ prefix from test functions #1720

senekor opened this issue Sep 9, 2023 · 1 comment · Fixed by #1727

Comments

@senekor
Copy link
Contributor

senekor commented Sep 9, 2023 •
edited
Loading

As far as I can tell, this prefix is not idiomatic.
All test functions are annotated with #[test], so it's not necessary for identification.

After a quick search, I couldn't find any considered-to-be-idiomatic sources which actually do this.
For example, the official book doesn't in its chapter on testing.
@senekor
Copy link
Contributor Author

senekor commented Sep 11, 2023

And some tests don't have this prefix right now, so it isn't even consistent at the moment.

@senekor senekor mentioned this issue Sep 11, 2023
Merged
senekor added a commit that referenced this issue Sep 11, 2023
@senekor
Remove test_ prefix from tests
a4d3b6b 
closes #1720
senekor added a commit that referenced this issue Sep 11, 2023
@senekor
Remove test_ prefix from tests
883e45d 
closes #1720
senekor added a commit that referenced this issue Sep 11, 2023
@senekor
Remove test_ prefix from tests
c4a2c76 
closes #1720
senekor added a commit that referenced this issue Sep 12, 2023
@senekor
Remove test_ prefix from tests
321824b 
closes #1720
senekor added a commit that referenced this issue Sep 12, 2023
@senekor
Remove test_ prefix from tests
08ee069 
closes #1720
senekor added a commit that referenced this issue Sep 12, 2023
@senekor
Remove test_ prefix from tests
655c176 
closes #1720
senekor added a commit that referenced this issue Sep 13, 2023
@senekor
Remove test_ prefix from tests
4696194 
closes #1720
senekor added a commit that referenced this issue Sep 14, 2023
@senekor
Remove test_ prefix from tests
8f44f00 
closes #1720
senekor added a commit that referenced this issue Sep 14, 2023
@senekor
Remove test_ prefix from tests (#1727)
62d7480 
closes #1720
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove test_ prefix from tests exercism/rust
1 participant
@senekor