Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement exercise food-chain #755

Merged
merged 10 commits into from
Oct 15, 2017

Conversation

luanjpb
Copy link
Contributor

@luanjpb luanjpb commented Oct 6, 2017


Fixes #750

@ilya-khadykin ilya-khadykin changed the title Implement exercise food-chain [WIP] Implement exercise food-chain Oct 7, 2017
@luanjpb luanjpb closed this Oct 7, 2017
@luanjpb luanjpb reopened this Oct 7, 2017
@luanjpb luanjpb closed this Oct 7, 2017
@luanjpb luanjpb reopened this Oct 7, 2017
@luanjpb luanjpb closed this Oct 7, 2017
@luanjpb luanjpb reopened this Oct 9, 2017
@luanjpb luanjpb changed the title [WIP] Implement exercise food-chain Implement exercise food-chain Oct 9, 2017
@ilya-khadykin
Copy link
Contributor

@LU4XLII could you please fix code style issues:

2.78s$ flake8
./exercises/food-chain/example.py:33:80: E501 line too long (80 > 79 characters)
./exercises/food-chain/food_chain_test.py:15:80: E501 line too long (92 > 79 characters)
./exercises/food-chain/food_chain_test.py:22:80: E501 line too long (92 > 79 characters)
./exercises/food-chain/food_chain_test.py:30:80: E501 line too long (92 > 79 characters)
./exercises/food-chain/food_chain_test.py:39:80: E501 line too long (92 > 79 characters)
./exercises/food-chain/food_chain_test.py:49:80: E501 line too long (92 > 79 characters)
./exercises/food-chain/food_chain_test.py:58:1: E302 expected 2 blank lines, found 1
./exercises/food-chain/food_chain_test.py:61:80: E501 line too long (82 > 79 characters)
./exercises/food-chain/food_chain_test.py:63:1: E305 expected 2 blank lines after class or function definition, found 1
The command "flake8" failed and exited with 1 during .

@luanjpb
Copy link
Contributor Author

luanjpb commented Oct 15, 2017

Fixed up

Copy link
Contributor

@ilya-khadykin ilya-khadykin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working on this

I've left a comment, please take a look



class FoodChainTest(unittest.TestCase):

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please implement other tests from https://github.com/exercism/problem-specifications/blob/master/exercises/food-chain/canonical-data.json

Could you also leave a comment stating what version of canonical-data.json the tests were adopted as discussed in #784 if applicable?
The format is:

# Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.0

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I'll work on this now.

@luanjpb
Copy link
Contributor Author

luanjpb commented Oct 15, 2017

All tests implemented

@ilya-khadykin ilya-khadykin merged commit 7f0fb4e into exercism:master Oct 15, 2017
@ilya-khadykin
Copy link
Contributor

Thanks for working on this, @LU4XLII 🏆

@luanjpb luanjpb deleted the food-chain-exercise branch October 19, 2017 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants