Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

food-chain: implement exercise #750

Closed
ilya-khadykin opened this issue Oct 6, 2017 · 8 comments
Closed

food-chain: implement exercise #750

ilya-khadykin opened this issue Oct 6, 2017 · 8 comments

Comments

@ilya-khadykin
Copy link
Contributor

There are exercises that are not yet implemented in Python track (the full list of them - #417 (comment)).
You can help us change this situation by implementing this one. Ref #417

The guide "Implement an exercise from specification" will help you succeed.

If you still have questions, I encourage you to ask them before starting working on the issue.

I also suggest claiming the issue by creating an empty PR as stated here

Please note that there are some special 'closing issue' keywords that you can put in description of your PR and Github will take care of closing the corresponding issue automatically after merge.
This simple thing helps us a lot, and makes our life a bit easier

@luanjpb
Copy link
Contributor

luanjpb commented Oct 6, 2017

Can i?

@ilya-khadykin
Copy link
Contributor Author

@LU4XLII sure, have fun
I suggest creating an empty [WIP] PR - https://github.com/exercism/docs/blob/master/you-can-help/implement-an-exercise-from-specification.md#avoiding-duplicate-work to claim it

@Rajdeep400
Copy link

can i ?

@ilya-khadykin
Copy link
Contributor Author

ilya-khadykin commented Oct 8, 2017

@Rajdeep400 I'd say yes since @LU4XLII the closed claiming PR

@LU4XLII, are you still working on this?

@luanjpb
Copy link
Contributor

luanjpb commented Oct 8, 2017

@m-a-ge I have made a second pull request with the complete exercise.

@ilya-khadykin
Copy link
Contributor Author

ilya-khadykin commented Oct 8, 2017

@LU4XLII could you reference this issue in your PR description to indicate that you're working on it?

It's generally not a good idea to close existing PR and creating a new one because it's harder for maintainers to track progress etc. If you are not sure how to update already opened PR, feel free to ask

@luanjpb
Copy link
Contributor

luanjpb commented Oct 9, 2017

@m-a-ge I have updated the original pull request and closed the second, is this ok now?

@ilya-khadykin
Copy link
Contributor Author

@LU4XLII give me some time to review it :godmode:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants