Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#1003][3.0] Window > ESC 기능 버그 수정 #1007

Merged
merged 4 commits into from
Jan 5, 2022
Merged

[#1003][3.0] Window > ESC 기능 버그 수정 #1007

merged 4 commits into from
Jan 5, 2022

Commits on Jan 4, 2022

  1. [#1003][3.0] Window > ESC 기능 버그 수정 

    ################
- watch를 통해 Window의 열림/닫힘 관리했던 코드 -> 라이프사이클 훅 사용하도록 변경
    @sej-dev
    sej-dev committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    6d1d688 View commit details
    Browse the repository at this point in the history

  2. [#1003][3.0] Window > ESC 기능 버그 수정 

    ################
- Window esc-close 관련하여 문서에 예시 코드 추가
    @sej-dev
    sej-dev committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    477e6b3 View commit details
    Browse the repository at this point in the history

  3. [#1003][3.0] Window > ESC 기능 버그 수정 

    ################
- onUpdated, onBeforeUpdate -> watch로 이동
- === false -> !
    @sej-dev
    sej-dev committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    c19006d View commit details
    Browse the repository at this point in the history

  4. [#1003][3.0] Window > ESC 기능 버그 수정 

    ################
- 간헐적으로 removeEventListener가 되지 않아 keydown 이벤트리스너가 중복 등록되는 문제 발생하여 관련 코드 제거
    @sej-dev
    sej-dev committed Jan 4, 2022
    Configuration menu
    Copy the full SHA
    5ffe966 View commit details
    Browse the repository at this point in the history