[#1003][3.0] Window > ESC 기능 버그 수정 #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
################ - watch를 통해 Window의 열림/닫힘 관리했던 코드 -> 라이프사이클 훅 사용하도록 변경
################ - Window esc-close 관련하여 문서에 예시 코드 추가
kdeun1
reviewed
Jan 4, 2022
################ - onUpdated, onBeforeUpdate -> watch로 이동 - === false -> !
################ - 간헐적으로 removeEventListener가 되지 않아 keydown 이벤트리스너가 중복 등록되는 문제 발생하여 관련 코드 제거
kdeun1
approved these changes
Jan 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[3.0] EVUI > Window ESC 기능 버그 수정
#996
Window에 Escape key 누르면 닫히는 기능 추가와 관련하여 버그 수정
[ 버그 상황 ]
v-for로 Draggable Window를 여러 개 열었을 때 가장 상단의 Window만 닫히고 나머지 Window는 닫히지 않음
[ 보완 내역 ]
Window가 열리고 닫히는 경우의 수를 lifecycle hook과 관련하여 세분화하여 개선