Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: undefined process after moving to webpack 5 #472

Closed
wants to merge 2 commits into from

Conversation

ccheraa
Copy link
Member

@ccheraa ccheraa commented Aug 2, 2021

Restore process variable in the browser using a Webpack plugin when the browser IDE is built in development mode.

@duncdrum duncdrum self-requested a review August 10, 2021 13:58
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my local system using electron identical with chrome:
Screenshot 2021-08-10 at 15 58 12

@ccheraa
Copy link
Member Author

ccheraa commented Aug 24, 2021

I'm hoping eclipse-theia/theia#9818 gets merged so we can avoid fixing this using workarounds.

@duncdrum duncdrum added regression High Priority High Priority expedite to unblock labels Sep 9, 2021
@duncdrum duncdrum marked this pull request as draft September 9, 2021 12:39
@ccheraa
Copy link
Member Author

ccheraa commented Sep 9, 2021

fixed in eclipse-theia/theia#9972 for v1.17.0
Once we upgrade to Theia 1.17.0 we should roll-back this PR

@duncdrum
Copy link
Contributor

fixed in eclipse-theia/theia#9972 for v1.17.0
Once we upgrade to Theia 1.17.0 we should roll-back this PR

please open an issue, as this comment will be hard to find once we merge this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed High Priority High Priority expedite to unblock regression
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants