fix: trying to access undefined process variable #9818
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Charafeddine Cheraa <ccheraa@gmail.com>
There was a problem hiding this comment.
@ccheraa thank you for taking care of the issue 👍
Please be sure to sign the eclipse contributor agreement (eca) with the same email as your authorship in order for us to accept the changes.
|
@vince-fugnitto I am having problems signing up to eclipse.org to be able to sign the eca, I will let you know when it's sorted out. |
| @@ -29,7 +29,7 @@ import { environment } from '@theia/core/shared/@theia/application-package/lib/e | |||
| export const WIN32_MAX_FILE_SIZE_MB = 300; // 300 MB | |||
| export const GENERAL_MAX_FILE_SIZE_MB = 16 * 1024; // 16 GB | |||
|
|
|||
| export const MAX_FILE_SIZE_MB = environment.electron.is() ? process.arch === 'ia32' ? WIN32_MAX_FILE_SIZE_MB : GENERAL_MAX_FILE_SIZE_MB : 32; | |||
| export const MAX_FILE_SIZE_MB = environment.electron.is() && 'process' in window ? process.arch === 'ia32' ? WIN32_MAX_FILE_SIZE_MB : GENERAL_MAX_FILE_SIZE_MB : 32; | |||
There was a problem hiding this comment.
I think it would be better to have:
export const MAX_FILE_SIZE_MB = typeof process === 'object'
? process.arch === 'ia32'
? WIN32_MAX_FILE_SIZE_MB
: GENERAL_MAX_FILE_SIZE_MB
: 32;
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This makes sure that the
filesystempackage accesses theprocessvariable only when it exists.See #9815 #9751 for more info
How to test
In our use case, we simply access the browser IDE from a Cypress test that's running on Electron.
The
filesystemwill throw an exception during its initialization, and the frontend will fail to load.This PR fixes that.
Review checklist
Reminder for reviewers