Skip to content
This repository has been archived by the owner on Apr 4, 2024. It is now read-only.

Fix ability to append log in tx post processing #1088

Merged
merged 2 commits into from
May 19, 2022

Conversation

thomas-nguy
Copy link
Contributor

Closes: #XXX

Description

Following #1025 ,

The result is not updated properly and the additional log in tx post processing are not persisted


For contributor use:

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer

For admin use:

  • Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
  • Reviewers assigned
  • Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

Copy link
Contributor

@fedekunze fedekunze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although ideally, we should only update the result if the log was modified. Can you add a changelog entry?

@codecov
Copy link

codecov bot commented May 19, 2022

Codecov Report

Merging #1088 (c8abf67) into main (d359cbd) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1088      +/-   ##
==========================================
- Coverage   59.49%   59.47%   -0.02%     
==========================================
  Files          84       84              
  Lines        6940     6942       +2     
==========================================
  Hits         4129     4129              
- Misses       2598     2600       +2     
  Partials      213      213              
Impacted Files Coverage Δ
x/evm/keeper/state_transition.go 75.07% <0.00%> (-0.47%) ⬇️

@fedekunze fedekunze enabled auto-merge (squash) May 19, 2022 06:46
auto-merge was automatically disabled May 19, 2022 06:57

Head branch was pushed to by a user without write access

@thomas-nguy thomas-nguy force-pushed the thomas/fix-post-processing-log branch from 303bc99 to c8abf67 Compare May 19, 2022 06:57
@fedekunze fedekunze merged commit 9edc87d into evmos:main May 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants