Allow to append logs after a post processing hook

[thomas-nguy]

Closes: #1024

Description

Add the ability to append log to the receipt after a tx post processing hook

more information on the issue ticket.

open for discussion

---

For contributor use:

• Targeted PR against correct branch (see CONTRIBUTING.md)
• Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
• Code follows the module structure standards.
• Wrote unit and integration tests
• Updated relevant documentation (docs/) or specification (x/<module>/spec/)
• Added relevant godoc comments.
• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Re-reviewed Files changed in the Github PR explorer

---

For admin use:

• Added appropriate labels to PR (ex. WIP, R4R, docs, etc)
• Reviewers assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[codecov]

Codecov Report

Merging #1025 (8d751c6) into main (8202a09) will decrease coverage by 0.00%.
The diff coverage is 82.14%.

❗ Current head 8d751c6 differs from pull request most recent head 711ae62. Consider uploading reports for the commit 711ae62 to get more accurate results

@@            Coverage Diff             @@
##             main    #1025      +/-   ##
==========================================
- Coverage   59.16%   59.15%   -0.01%     
==========================================
  Files          80       80              
  Lines        6577     6576       -1     
==========================================
- Hits         3891     3890       -1     
  Misses       2467     2467              
  Partials      219      219              

Impacted Files	Coverage Δ
x/evm/keeper/state_transition.go	75.54% <82.14%> (-0.08%)	⬇️

[fedekunze]

Can't you just modify the logs from the receipt?

[thomas-nguy]

Yes, but the computation of the bloom needs to be moved down nevertheless.

Do you prefer to have this ability implicitly and keep the previous signature?

[fedekunze]

Yes, but the computation of the bloom needs to be moved down nevertheless.

Why? if you are updating the logs then you should also be updating the bloom during the post tx processing step. We'd need to change the state transition to do the following instead:

	if len(receipt.Logs) > 0 {
		// Update transient block bloom filter
		k.SetBlockBloomTransient(ctx, receipt.Bloom)
		k.SetLogSizeTransient(ctx, uint64(txConfig.LogIndex)+uint64(len(receipt.Logs)))
	}

[thomas-nguy]

okay, make sense. Published a minimal change version

[fedekunze]

LGTM