TWC/Tesla: use charger api.PhaseCurrents over vehicle api.CurrentGetter #14659
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of TWC/Tesla, we're expiring the rate limit due to #14226 when charging below 6A since Tesla needs validation if limit really is applied on vehicle (most likely, that's a vehicle bug). For this purpose,
api.CurrentGetter
has been added on Tesla and is relayed by TWC to the vehicle if connected.With #14622, instead of using charger's
api.CurrentGetter
(which relays to vehicle'sapi.CurrentGetter
in case of TWC) we can resort to charger'sapi.PhaseCurrents
to determine charging above limit as fallback. This PR ensures that the fallback is used by removing the Tesla'sapi.CurrentGetter
and ensuring that charger'sapi.PhaseCurrents
is invoked onapi.ErrNotAvailable
returned by TWC.Supports #14616