Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loadpoint: use measured phases/currents as fallback to api.PhaseGetter, api.GetMaxCurrent #14622

Merged
merged 5 commits into from
Jun 29, 2024

Conversation

andig
Copy link
Member

@andig andig commented Jun 29, 2024

Fix #14443

@GrimmiMeloni the change is two-fold:

General:

  • extract the common && enabled condition to the switch (its obvious from the diff that this can be hoisted)

Phases:

  • only evaluate if shouldBeConsistent && phases > 0
  • use measuredPhases as go-in value, corrected for 2 active phases

Currents:

  • use measured currents instead of set current as fallback

wdyt?

/cc @MarkusGH

@andig andig added the enhancement New feature or request label Jun 29, 2024
@andig

This comment was marked as resolved.

@andig andig changed the title Loadpoint: use measured phases as fallback to api.PhaseGetter Loadpoint: use measured phases/currents as fallback to api.PhaseGetter, api.GetMaxCurrent Jun 29, 2024
Copy link
Collaborator

@GrimmiMeloni GrimmiMeloni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. See detailed question around chargerPhases > 0 - but it is more for my understanding.

core/loadpoint.go Show resolved Hide resolved
core/loadpoint.go Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loadpoint: Loadpoint not scaling down
3 participants