-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
761 - Add a Connection - SaaS connector's configuration parameters 984 - Saas Connector configuration - left navigation to toggle between connection params and dataset config 985 - SaaS Connector Configuration - Testing a Connection
By default, turning off the createNewConnection flag which is still under development.
.../ops/admin-ui/src/features/datastore-connections/add-connection/sass/ConnectorParameters.tsx
Outdated
Show resolved
Hide resolved
useEffect(() => { | ||
updateCachedFilters.current(filters); | ||
}, [setCachedFilters, filters]); | ||
|
||
const { data, isFetching, isLoading, isSuccess } = | ||
useGetAllConnectionTypesQuery(cachedFilters); | ||
|
||
const handleSearchChange = (event: React.ChangeEvent<HTMLInputElement>) => |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add some constraints here, like debouncing or a minimum search term length before we send anything off to the API?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a debounce on line 35. I do agree maybe we increase the milliseconds from 250 to 500 and have a minimum character limit of 2. Your thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have added this to a follow-up
.../ops/admin-ui/src/features/datastore-connections/add-connection/sass/ConnectorParameters.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work here @chriscalhoun1974, in testing this I've logged the following issues but none are blockers:
* Sass Connecter feature development 761 - Add a Connection - SaaS connector's configuration parameters 984 - Saas Connector configuration - left navigation to toggle between connection params and dataset config 985 - SaaS Connector Configuration - Testing a Connection * Skipping unit test temporarily * Update flags.json file By default, turning off the createNewConnection flag which is still under development. * Updated CHANGELOG.md file * Resolved ESLint issues * Resolved npm build issue * Resolved npm build issue * Updated Saas connector configuration * Updated Saas connector configuration * Removed unnecessary import statement * add new privilege for creating SaaS connectors to user management interface * add connections read as a privilege * Applied code review feedback * Updated the CSS visibility of the CircleHelpIcon component * Added toast success when a user creates a Saas config * Resolved ESLint issue Co-authored-by: Sean Preston <sean@ethyca.com>
Purpose
When a user clicks the "Create New Connection" button, display a series of screens which allow the user to select a given Sass connector and configure connector configuration info.
Changes
Checklist
CHANGELOG.md
fileCHANGELOG.md
file is being appended toUnreleased
section in an appropriate category. Add a new category from the list at the top of the file if the needed one isn't already there.Run Unsafe PR Checks
label has been applied, and checks have passed, if this PR touches any external servicesTicket
Fixes #761 #984 #985