-
Notifications
You must be signed in to change notification settings - Fork 773
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking Releases #2945
Breaking Releases #2945
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
…ency versions (Block)
…ency versions (Blockchain)
…ency versions (Common)
…ency versions (devp2p)
…ency versions (Ethash)
…ency versions (EVM)
…ency versions (Genesis)
…ency versions (RLP)
…ency versions (StateManager)
…ency versions (Trie)
e283863
to
7d68c68
Compare
Ok, this is now ready for review! 🙂 Releases are targeted for tomorrow (Wednesday, August 9). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Side note: blockchain has no changes to docs, is this correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
One side question, should we update the library author to be EthereumJS team and change current authors to contributors in each package.json (kind of like we currently have in util
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Left 2 minor comments that I'll apply
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small nit...
@gabrocheleau thanks for the updates! @acolytec3 Guess we can do (update authors/contributors), wouldn't do in this PR though, if we want we can do separately in a follow-up PR Side note to all: please do not update this branch right now or anything, I am doing some local stuff and will do later myself. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just published the following releases on npm:
|
See: #2561
Follow-up on #2876
Final releases for the EthereumJS breaking release round from Summer 2023! 🥳
This includes a ton of changes and it is highly recommended to have a look at the release notes for the various libraries.