Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking Releases #2945

Merged
merged 25 commits into from
Aug 9, 2023
Merged

Breaking Releases #2945

merged 25 commits into from
Aug 9, 2023

Conversation

holgerd77
Copy link
Member

See: #2561
Follow-up on #2876

Final releases for the EthereumJS breaking release round from Summer 2023! 🥳

This includes a ton of changes and it is highly recommended to have a look at the release notes for the various libraries.

@codecov
Copy link

codecov bot commented Aug 8, 2023

Codecov Report

Merging #2945 (6132bec) into master (fa8a518) will decrease coverage by 6.10%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
ethash ∅ <ø> (?)
evm 69.93% <ø> (?)
rlp ?
statemanager ?
tx 95.96% <ø> (?)
util 86.77% <ø> (ø)
vm 79.20% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77
Copy link
Member Author

Ok, this is now ready for review! 🙂 Releases are targeted for tomorrow (Wednesday, August 9).

jochem-brouwer
jochem-brouwer previously approved these changes Aug 8, 2023
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Side note: blockchain has no changes to docs, is this correct?

acolytec3
acolytec3 previously approved these changes Aug 8, 2023
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

One side question, should we update the library author to be EthereumJS team and change current authors to contributors in each package.json (kind of like we currently have in util?

gabrocheleau
gabrocheleau previously approved these changes Aug 8, 2023
Copy link
Contributor

@gabrocheleau gabrocheleau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Left 2 minor comments that I'll apply

@gabrocheleau gabrocheleau dismissed stale reviews from acolytec3 and themself via fe38530 August 8, 2023 15:20
gabrocheleau
gabrocheleau previously approved these changes Aug 8, 2023
Copy link
Contributor

@scorbajio scorbajio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit...

packages/devp2p/CHANGELOG.md Outdated Show resolved Hide resolved
@holgerd77
Copy link
Member Author

@gabrocheleau thanks for the updates!

@acolytec3 Guess we can do (update authors/contributors), wouldn't do in this PR though, if we want we can do separately in a follow-up PR

Side note to all: please do not update this branch right now or anything, I am doing some local stuff and will do later myself. Thanks!

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@holgerd77 holgerd77 merged commit c47d2c7 into master Aug 9, 2023
@holgerd77 holgerd77 deleted the breaking-releases branch August 9, 2023 11:22
@holgerd77
Copy link
Member Author

Just published the following releases on npm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants