Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC1 Releases #2876

Merged
merged 38 commits into from
Jul 17, 2023
Merged

RC1 Releases #2876

merged 38 commits into from
Jul 17, 2023

Conversation

holgerd77
Copy link
Member

See: #2561
Follow-up on #2832

Release Candidate 1 versions preparing for the breaking release round for EthereumJS libraries planned in July 2023, part 2 of the release prepartion including library version updates, updated upstream dependency versions, README updates and docs updates.

Particularities:

  • First @ethereumjs/wallet release within the new namespace (as RC1 as well)
  • Client release included, no RC1 but normal release

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Merging #2876 (708c391) into master (0af7309) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 88.66% <100.00%> (+0.04%) ⬆️
blockchain 92.58% <ø> (ø)
client 87.20% <100.00%> (+<0.01%) ⬆️
common 97.13% <ø> (ø)
ethash ?
evm 69.95% <ø> (+0.33%) ⬆️
rlp ∅ <ø> (∅)
statemanager 85.16% <ø> (ø)
trie 90.25% <ø> (+0.21%) ⬆️
tx 95.96% <ø> (ø)
util 86.77% <ø> (-0.38%) ⬇️
vm 78.15% <ø> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with these edits!

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverting previous erroneous approval

@holgerd77 holgerd77 dismissed acolytec3’s stale review July 12, 2023 07:29

Accidental review, will dismiss.

@holgerd77
Copy link
Member Author

Ok, PR is now up for a first round of reviews. 🙂

So all README files are updated and all version numbers should be updated (please explicitly review this as well).

Not completely ready though, so I have not yet integrated the latest work, will do this on likely Monday and then open up for final approval.

Nevertheless if the current state of the PR would get a full review until the weekend so that we have this out of the way.

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment: have reviewed so far the READMEs and the package.json's, (not the generated docs). Have to give this another round though.

@holgerd77
Copy link
Member Author

Hi @scorbajio, sorry, I do not understand these two additional commits and I would therefore remove them.

@holgerd77
Copy link
Member Author

@scorbajio if you do would want to do other changes around this please do not do on this PR but on a separate PR. If I am not totally overlooking something these changes should not be relevant for the release candidate releases though.

@holgerd77
Copy link
Member Author

Ready for review. 🙂

Some procedural notes: since I won't have time to work tomorrow afternoon and most of Wednesday a review in next 2 hours would help me in the form that I could then eventually already do the releases itself this afternoon and would have some more dedicated "marketing"/communication time tomorrow morning (I would do the "main" marketing along final releases though, but think here this also helps if we are doing some communication already to raise awareness and encourage people to try out).

Also: I am already doing some local udpates on th PR which I won't directly push (too tiny + incremental), since I am also cross-reading right now. Please therefore do not directly push updates on the branch if you review but only comment.

Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/block/README.md Show resolved Hide resolved
packages/block/README.md Show resolved Hide resolved
packages/blockchain/README.md Show resolved Hide resolved
packages/blockchain/README.md Show resolved Hide resolved
packages/blockchain/README.md Show resolved Hide resolved
packages/common/README.md Show resolved Hide resolved
packages/common/README.md Show resolved Hide resolved
@holgerd77 holgerd77 merged commit 66c98f3 into master Jul 17, 2023
@holgerd77 holgerd77 deleted the rc1-releases branch July 17, 2023 13:51
@holgerd77
Copy link
Member Author

holgerd77 commented Jul 17, 2023

Just published the following releases on npm:

Additional note: second EVM release RC.2 was necessary due to missing StateManager dependency, have done locally, code will be submitted in a follow-up PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants