-
Notifications
You must be signed in to change notification settings - Fork 776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RC1 Releases #2876
RC1 Releases #2876
Conversation
Codecov Report
Additional details and impacted files
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with these edits!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverting previous erroneous approval
Ok, PR is now up for a first round of reviews. 🙂 So all README files are updated and all version numbers should be updated (please explicitly review this as well). Not completely ready though, so I have not yet integrated the latest work, will do this on likely Monday and then open up for final approval. Nevertheless if the current state of the PR would get a full review until the weekend so that we have this out of the way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Comment: have reviewed so far the READMEs and the package.json's, (not the generated docs). Have to give this another round though.
Hi @scorbajio, sorry, I do not understand these two additional commits and I would therefore remove them. |
@scorbajio if you do would want to do other changes around this please do not do on this PR but on a separate PR. If I am not totally overlooking something these changes should not be relevant for the release candidate releases though. |
…ed LICENSE file (Genesis)
Ready for review. 🙂 Some procedural notes: since I won't have time to work tomorrow afternoon and most of Wednesday a review in next 2 hours would help me in the form that I could then eventually already do the releases itself this afternoon and would have some more dedicated "marketing"/communication time tomorrow morning (I would do the "main" marketing along final releases though, but think here this also helps if we are doing some communication already to raise awareness and encourage people to try out). Also: I am already doing some local udpates on th PR which I won't directly push (too tiny + incremental), since I am also cross-reading right now. Please therefore do not directly push updates on the branch if you review but only comment. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Just published the following releases on npm:
Additional note: second EVM release RC.2 was necessary due to missing StateManager dependency, have done locally, code will be submitted in a follow-up PR. |
See: #2561
Follow-up on #2832
Release Candidate 1 versions preparing for the breaking release round for EthereumJS libraries planned in July 2023, part 2 of the release prepartion including library version updates, updated upstream dependency versions, README updates and docs updates.
Particularities:
@ethereumjs/wallet
release within the new namespace (as RC1 as well)