Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New EVM Bugfix Release v1.2.2 #2384

Merged
merged 2 commits into from
Oct 26, 2022
Merged

New EVM Bugfix Release v1.2.2 #2384

merged 2 commits into from
Oct 26, 2022

Conversation

holgerd77
Copy link
Member

Follow-up on #2380

Small bugfix release for the EVM (no other code changes since last relase) to include the last two bugfixes regarding EIP-3540 and empty account handling.

Open for review. 🙂

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If @acolytec3 suggestion is merged then LGTM!

packages/evm/CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah wait, also include #2383, this fixes consensus bugs!

Copy link
Member

@jochem-brouwer jochem-brouwer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait dismiss my last review, it's in the changelog

Co-authored-by: acolytec3 <17355484+acolytec3@users.noreply.github.com>
Copy link
Contributor

@acolytec3 acolytec3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #2384 (1c88a88) into master (985f2aa) will decrease coverage by 1.79%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

Flag Coverage Δ
block 91.37% <ø> (ø)
blockchain 90.21% <ø> (ø)
client 87.04% <ø> (ø)
common 98.13% <ø> (ø)
devp2p 91.54% <ø> (-0.09%) ⬇️
ethash ∅ <ø> (∅)
evm 79.50% <ø> (?)
rlp ?
statemanager 89.46% <ø> (ø)
trie 90.36% <ø> (ø)
tx 97.80% <ø> (ø)
util 83.89% <ø> (ø)
vm 85.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@holgerd77 holgerd77 merged commit cc5bb59 into master Oct 26, 2022
@gitpoap-bot
Copy link

gitpoap-bot bot commented Oct 26, 2022

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 EthereumJS Contributor:

GitPOAP: 2022 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

@holgerd77 holgerd77 deleted the new-evm-bugfix-release branch October 26, 2022 16:39
@acolytec3
Copy link
Contributor

Congrats, your important contribution to this open-source project has earned you a GitPOAP!

GitPOAP: 2022 EthereumJS Contributor:

GitPOAP: 2022 EthereumJS Contributor GitPOAP Badge

Head to gitpoap.io & connect your GitHub account to mint!

Learn more about GitPOAPs here.

Does this bot not know when a given GitHub Id has contributed to a repo?

@holgerd77
Copy link
Member Author

Just published the following releases on npm:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants