Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(util): enable strict-boolean-expressions rule for eslint #2148

Closed
wants to merge 8 commits into from
Closed

chore(util): enable strict-boolean-expressions rule for eslint #2148

wants to merge 8 commits into from

Conversation

faustbrian
Copy link
Contributor

@faustbrian faustbrian commented Aug 16, 2022 •
edited
Loading

Part of #2137 and depends on #2147 being merged

@faustbrian faustbrian mentioned this pull request Aug 16, 2022
Closed
@faustbrian faustbrian changed the title chore(util): enable strict-boolean-expressions rule for eslint chore(util): enable strict-boolean-expressions rule for eslint Aug 16, 2022
@codecov
Copy link

codecov bot commented Aug 16, 2022 •
edited
Loading

Codecov Report

Merging #2148 (bb829f9) into master (a87f179) will decrease coverage by 0.68%.
The diff coverage is 95.00%.

Impacted file tree graph

Flag Coverage Δ
block 92.77% <100.00%> (ø)
blockchain ?
client 87.07% <ø> (ø)
common 98.09% <83.33%> (ø)
devp2p 92.11% <ø> (-0.19%) ⬇️
ethash ?
evm 79.08% <ø> (ø)
rlp ∅ <ø> (∅)
statemanager 88.16% <ø> (ø)
trie 89.43% <100.00%> (ø)
tx ?
util 92.33% <100.00%> (ø)
vm 85.27% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@faustbrian
Copy link
Contributor Author

Closing this since it falls in the same category as Uint8Array in terms of breaking changes/impact.

@faustbrian faustbrian closed this Oct 15, 2022
@faustbrian faustbrian deleted the strict-util branch October 15, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ryanio ryanio

@acolytec3 acolytec3

@gabrocheleau gabrocheleau

Labels
package: monorepo PR state: do-not-merge PR state: needs review type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@faustbrian @ryanio @acolytec3 @gabrocheleau