chore(tx): enable strict-boolean-expressions rule for eslint
#2147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustbrian
changed the title
strict-boolean-expressions rule for eslint
Codecov Report
Flags with carried forward coverage won't be shown. Click here to find out more. |
faustbrian
commented
Aug 16, 2022
| @@ -29,20 +29,20 @@ export async function getTests( | |||
| excludeDir, | |||
| } | |||
| return new Promise((resolve, reject) => { | |||
| const finishedCallback = (err: Error | undefined, files: string[]) => { | |||
| if (err) { | |||
| const finishedCallback = (err: Error | null, files: string[]) => { | |||
There was a problem hiding this comment.
This type was wrong. The err value actually comes back as null if it isn't defined. Noticed this because tests started to fail when I checked for undefined instead of null.
faustbrian
commented
Aug 16, 2022
| reject(err) | ||
| return | ||
| } | ||
| resolve(files) | ||
| } | ||
| const fileCallback = async ( | ||
| err: Error | undefined, | ||
| err: Error | null, |
There was a problem hiding this comment.
This type was wrong. The err value actually comes back as null if it isn't defined. Noticed this because tests started to fail when I checked for undefined instead of null.
12 tasks
|
Closing this since it falls in the same category as |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #2137 and depends on #2146 and #2150 being merged