Update EOF validation test for top-level containers #1381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
winsvega
reviewed
Jun 12, 2024
| @@ -92,6 +92,8 @@ validInvalid: | |||
| 00 # 3 STOP | |||
| # Data segment | |||
| 0bad # 2 bytes instead of four | |||
| expectException: | |||
| "Prague" : "err: toplevel_container_truncated" | |||
There was a problem hiding this comment.
you can use pyspec exception style now
EOFException.TOPLEVEL_CONTAINER_TRUNCATED
winsvega
reviewed
Jun 12, 2024
| @@ -116,7 +118,7 @@ validInvalid: | |||
| # Data segment | |||
| 0bad60A70BAD # 6 bytes instead of four | |||
| expectException: | |||
| ">=Prague" : "EOF_InvalidSectionBodiesSize" | |||
| "Prague" : "EOF_InvalidSectionBodiesSize" | |||
There was a problem hiding this comment.
but legacy exceptions are also fine. we are planning to convert json tests into .py eventually anyway
winsvega
reviewed
Jun 12, 2024
| } | ||
| } | ||
| }, | ||
| "EOF1_truncated_section_4": { | ||
| "code": "0xef000101000402000100010400020000800000feaa", | ||
| "results": { | ||
| "Prague": { | ||
| "result": true | ||
| "exception": "err: toplevel_container_truncated", |
There was a problem hiding this comment.
please use the error code. EOFException.TOPLEVEL_CONTAINER_TRUNCATED or retetesteth style
|
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Aug 8, 2024
Switch to the updated `eof-toplevel` branch of ipsilon/tests. After rebasing the number of changes is smaller than it was. The ethereum/tests PR: ethereum/tests#1381.
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Aug 8, 2024
Switch to the updated `eof-toplevel` branch of ipsilon/tests. After rebasing the number of changes is smaller than it was. The ethereum/tests PR: ethereum/tests#1381. Also run the EOF tests from upstream ethereum/tests v14.0 with longer exclusion list.
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Aug 8, 2024
Switch to the updated `eof-toplevel` branch of ipsilon/tests. After rebasing the number of changes is smaller than it was. The ethereum/tests PR: ethereum/tests#1381. Also run the EOF tests from upstream ethereum/tests v14.0 with longer exclusion list.
chfast
added a commit
to ethereum/evmone
that referenced
this pull request
Aug 8, 2024
Switch to the updated `eof-toplevel` branch of ipsilon/tests. After rebasing the number of changes is smaller than it was. The ethereum/tests PR: ethereum/tests#1381. Also run the EOF tests from upstream ethereum/tests v14.0 with longer exclusion list.
- EOFTests/EIP3540/validInvalid.json: ethereum/execution-spec-tests#598 - EOFTests/efValidation/EOF1_truncated_section_.json: ethereum/execution-spec-tests#740 - EOFTests/efValidation/EOF1_eofcreate_valid_.json: ethereum/execution-spec-tests#738
- Update tests because of the validation rule change: top-level containers must not have truncated data. - Fix some expected error messages. - Change ">=Prague" to "Prague" because not supported in retesteth.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
containers must not have truncated data.