Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new(tests): EOF - EIP-3540: Migrate validation tests: EIP3540/validInvalidFiller.yml #598

Merged
merged 9 commits into from
Aug 16, 2024

Conversation

chfast
Copy link
Member

@chfast chfast commented Jun 6, 2024

🗒️ Description

Migrate https://github.com/ethereum/tests/blob/develop/src/EOFTestsFiller/EIP3540/validInvalidFiller.yml.

✅ Checklist

  • All: Set appropriate labels for the changes.
  • All: Considered squashing commits to improve commit history.
  • All: Added an entry to CHANGELOG.md.
  • All: Considered updating the online docs in the ./docs/ directory.
  • Tests: All converted JSON/YML tests from ethereum/tests have been added to converted-ethereum-tests.txt.
  • Tests: Included the type and version of evm t8n tool used to locally execute test cases: e.g., ref with commit hash or geth 1.13.1-stable-3f40e65.
  • Tests: Ran mkdocs serve locally and verified the auto-generated docs for new tests in the Test Case Reference are correctly formatted.

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments. I think the end-goal should be to get rid of tests/prague/eip7692_eof_v1/eip3540_eof_v1/container.py and place the tests it contains into several better categorized tests.

@chfast chfast force-pushed the eof/migrate_valid_invalid branch from 1864f0f to b5359a2 Compare June 12, 2024 13:17
@chfast chfast marked this pull request as draft June 12, 2024 13:26
@chfast
Copy link
Member Author

chfast commented Jun 12, 2024

I put it on hold because this is too fragile: it requires evmone, ethereum/tests and EEST to full agree.

@chfast chfast force-pushed the eof/migrate_valid_invalid branch 2 times, most recently from 1bc4bd1 to 342ab44 Compare August 8, 2024 15:21
@chfast chfast marked this pull request as ready for review August 8, 2024 16:00
@chfast chfast force-pushed the eof/migrate_valid_invalid branch 2 times, most recently from 4331a25 to 9f3b678 Compare August 9, 2024 09:42
@chfast
Copy link
Member Author

chfast commented Aug 9, 2024

Because the coverage comparison only considers the newly added python file removing duplicated tests is impractical. I'm not sure how do you want to handle this.

Moreover, the coverage report also points to the lost coverage in the "bytes to hex" helper functions. I don't know why exactly this happens but these are irrelevant. Quick fix is probably to exclude EVMC from the coverage.

image

@chfast
Copy link
Member Author

chfast commented Aug 16, 2024

Should I push these tests further?

Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@marioevz marioevz changed the title Migrate EOF validation tests: EIP3540/validInvalidFiller.yml new(tests): EOF - EIP-3540: Migrate validation tests: EIP3540/validInvalidFiller.yml Aug 16, 2024
@marioevz marioevz merged commit ccfd9ca into ethereum:main Aug 16, 2024
6 checks passed
@marioevz marioevz deleted the eof/migrate_valid_invalid branch August 16, 2024 16:07
chfast added a commit to ethereum/tests that referenced this pull request Aug 19, 2024
- EOFTests/EIP3540/validInvalid.json: ethereum/execution-spec-tests#598
- EOFTests/efValidation/EOF1_truncated_section_.json: ethereum/execution-spec-tests#740
- EOFTests/efValidation/EOF1_eofcreate_valid_.json: ethereum/execution-spec-tests#738
winsvega pushed a commit to ethereum/tests that referenced this pull request Aug 20, 2024
- EOFTests/EIP3540/validInvalid.json: ethereum/execution-spec-tests#598
- EOFTests/efValidation/EOF1_truncated_section_.json: ethereum/execution-spec-tests#740
- EOFTests/efValidation/EOF1_eofcreate_valid_.json: ethereum/execution-spec-tests#738
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants