Highlander uncles #401
Highlander uncles #401
Conversation
|
This breaks consensus. Protocol suggestions go elsewhere. |
|
There’s going to be a bunch of things coming this weekend that break consensus. Anyhow, if you don’t limit the number of uncles, real world miners have told me they’ll mine them and there will be hyper-inflation. This isn’t theoretical economics. On Feb 28, 2015, at 3:10 PM, Jeffrey Wilcke notifications@github.com wrote:
|
|
@xcthulhu Hi! Thanks for the PR - it's indeed a real issue. We have a number of current issues around uncles from several sources, including security auditors, e.g. #387 and #381 However, we should define all agreed upon changes to consensus, such as uncle validation logic and uncle rewards in the yellow paper before we add them to the Go client. This will make it easier for us to keep track of all current changes to consensus, and avoid cases where the Go client is "right" and the YP "wrong". Please sync with @vbuterin and @gavofyork regarding this and feel free to open a PR to https://github.com/ethereum/yellowpaper/blob/master/Paper.tex#L975 |
|
Hello, Your friend Matthew sent you a message 36h days ago, which is still unread. Within 24 hours the message will be deleted. If you are curious to what Matthew wrote you click here: a.iqelite.com/entry/new_message/304c5d3a9b82edb35f6db34c2d3fda9e1f544b80bfb/320c612f7502e5151515f9060c467a891a85f8ab0af906d91bd82825f8983bd7489586eb67b7b665175cb59b0c459af515f7b5f666ebd9060b7cb515151515151515858585191c460a9af9060a8587b91b7c4516689826d75becbc320c612f75044d3e22edb35af44b80bfb/?hg=uUDrPi40N8 Regards, This message was meant for reply@reply.github.com. If you do not want to continue receiving such mails from IQ Elite, please click on this link: a.iqelite.com/common/unsubscribe/?code=a180b7bb&email=reply@reply.github.com&hg=uUDrPi40N8 IQ Elite is a service with main office: C/ Gran De Gràcia 15, 1a 1a, 08012 Barcelona, Spain. |
|
@xcthulhu dude .... you really gotta get rid of that stuff |
* add proof for predeployed storages * reverse inneeded code * update for mainbranch merging * add pertx storage trace * dummy tx proof * add txstorage trace * add coinbase storage as trace * enable (sync) tracing by default * basic * init cgo framework * fix break loop * integrate the right zkevm version (ethereum#323) * finish rust codes * use dylib (ethereum#325) * flip * ? * use cdylib * revert * fix * apply_tx * rename * fixing types fixing types fixing types * clean up * ExecutionResults (ethereum#328) * filling * filling * more * clean up * filling * coinbase * add * MPTWitness * ExecutionResults WIP * L1fee L1fee * sender * to * Failed & ReturnValue * createdAcc & after * remove MPTWitness * txStorageTrace * add FeeRecipient * add StorageTrace * fix FFI types * better logger * cargo fmt * fix * add build tags * update Makefile * fix library * improve ld path * correctly deal with circuit_capacity_checker returned result * fix return value * update cargo (ethereum#333) * update cargo * update * update go * refactor * raname `circuits capacity checker` to `circuit capacity checker` * some refactorings * [Fix] storage proof generation in capacity checker (ethereum#348) * make per-tx storage and deletion proof work * format * fix misplaced markdeletion --------- Co-authored-by: HAOYUatHZ <haoyu@protonmail.com> * docker (ethereum#363) * update Dockerfile * build: update go version to 1.19 * update * fix * fix * try * simplify * revert go version update l2geth Dockerfiles * fix * fix coinbase * fix (ethereum#369) * format * Update version.go * address comments * Capacity refactor (ethereum#374) * init * id * support multiple instances * fix id * fix conflicts * refactor to use same codes (ethereum#379) * re-init * WIP * WIP * refactor * go * minor * fix storage proof of l1gas price oracle * move 1 * move 2 * move 3 * move 4 * move 5 move 5 * move 6 move 6 * move 7 * move 8 * move 9 * move 10 * clean up clean up --------- Co-authored-by: Ho Vei <noelwei@gmail.com> * finish basic * minor * config capacity check in block_validator (ethereum#380) * init * done ref * fix tests fix tests fix tests fix tests * add more comments * apply_block * improve logs * cargo fmt * Capacity big refactor (ethereum#383) * CreateTraceEnv * WIP * draft more fix * for test * fortet * clean up * add more comments * goimports -local github.com/scroll-tech/go-ethereum -w . * fix typos * attempt 1 * attempt 2 * attempt 3 * gogogo * clean up * fix * fix * rename * minor * fix * minor * minor * improve doc * use dedicated `checkCircuitCapacity` flag (ethereum#394) * refactor * fix * add lock * [feat] capacity checking: upgrade libzkp (ethereum#395) * upgrade * upgrade libzkp * write RowConsumption (ethereum#396) * write RowConsumption * name alignments * revert some formatting * add lock to CircuitCapacityChecker in BlockValidator * remove mutex pointer * improve github workflow * improve * store row consumption in mining (ethereum#397) * prepare * finish * add more logs * mark `ApplyBlock` as ready * update libzkp (ethereum#401) * fix * Capacity detail (ethereum#402) * fix(block-validation): consider skipping in ValidateL1Messages (ethereum#405) * fix(block-validation): consider skipping in ValidateL1Messages * fix(block): consider skipping in L1MessageCount * fix l1 validation tests * fix NumL1Messages * fix impl.go return types fix * better error handling (ethereum#407) * add add * add * add * add * add * cargo fmt * add * update * add * WIP * minor * gogogo * gogogo * fix * fix * fix * cargo clippy * improve * improve * creation lock (ethereum#408) * creation lock * update * Debug log (ethereum#409) * add more logs * more * more * fix * improve * Update cmd/utils/flags.go Co-authored-by: Péter Garamvölgyi <peter@scroll.io> * refactor worker.commit() * avoid re-calculate * txpool ccc err handling (ethereum#411) * more explicit error comments * add more logs * fix unnecessary commit * add more logs * fix `ineffassign` * add more comments * log id for `NewCircuitCapacityChecker` (ethereum#414) add log to `NewCircuitCapacityChecker` * Persist skip info for block where all L1 msgs are skipped (ethereum#415) persist skip info for block where all L1 msgs are skipped * Update version.go --------- Co-authored-by: Ho Vei <noelwei@gmail.com> Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com> Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
* trie/verkle: change tree key generation Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * fix tests Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> * update go-verkle Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com> --------- Signed-off-by: Ignacio Hagopian <jsign.uy@gmail.com>
…thereum#401) * RIN-02 Panic Due to Integer Overflow in Signature Size Calculation * assert the error * simply overflow check * simply overflow check --------- Co-authored-by: Liam Lai <liam.lai@datameshgroup.com>
Having arbitrary uncles runs the risk of hyper-inflating the economy. You should only allow for one uncle.
Vitalik's tests predict that there will be an average of 0.15 uncles, so limiting this to be one should be adequate.
https://blog.ethereum.org/2014/07/11/toward-a-12-second-block-time/