Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RPC eth_listening and eth_mining always returning false #323

Closed
jorisbontje opened this issue Feb 17, 2015 · 3 comments
Closed

RPC eth_listening and eth_mining always returning false #323

jorisbontje opened this issue Feb 17, 2015 · 3 comments

Comments

@jorisbontje
Copy link

With a mist node that is mining and connected to 2 peers, the RCP methods eth_listening and eth_mining always return False.

Request:

{'params': None, 'jsonrpc': '2.0', 'id': '54eab6cd-b22b-4328-9fa2-ba56f4ddea0a', 'method': 'eth_listening'}

Reponse:

{u'jsonrpc': u'2.0', u'id': u'54eab6cd-b22b-4328-9fa2-ba56f4ddea0a', u'result': False}

expected: result = True

Request:

{'params': None, 'jsonrpc': '2.0', 'id': '33a739cf-0f31-47af-b42e-52f5871c0cc0', 'method': 'eth_mining'}

Response:

{u'jsonrpc': u'2.0', u'id': u'33a739cf-0f31-47af-b42e-52f5871c0cc0', u'result': False}

expected: result = True

@jorisbontje
Copy link
Author

eth_listening is now correctly reporting, eth_mining is still always false when starting ethereum -rpc -mine=true, it works in mist though.

@jorisbontje
Copy link
Author

@obscuren please reopen as eth_mining is not correctly fixed when running: ethereum -rpc=true -mine=true

@jorisbontje
Copy link
Author

Fixed by fdf939a

tony-ricciardi pushed a commit to tony-ricciardi/go-ethereum that referenced this issue Jan 20, 2022
maoueh pushed a commit to streamingfast/go-ethereum that referenced this issue Dec 9, 2022
* update the default cli config

* fix: handle maxpeers flag override, added tests

* add: no-snapshot flag, handle snapshot disable

* fix: update default flags

* add: update the sealer.GasPrice default to 30 gewi

* fix: remove snapshot flag, rely on no-snapshot only
tanishqjasoria pushed a commit to tanishqjasoria/go-ethereum that referenced this issue Oct 31, 2023
* add proof for predeployed storages

* reverse inneeded code

* update for mainbranch merging

* add pertx storage trace

* dummy tx proof

* add txstorage trace

* add coinbase storage as trace

* enable (sync) tracing by default

* basic

* init cgo framework

* fix break loop

* integrate the right zkevm version (ethereum#323)

* finish rust codes

* use dylib (ethereum#325)

* flip

* ?

* use cdylib

* revert

* fix

* apply_tx

* rename

* fixing types

fixing types

fixing types

* clean up

* ExecutionResults (ethereum#328)

* filling

* filling

* more

* clean up

* filling

* coinbase

* add

* MPTWitness

* ExecutionResults WIP

* L1fee

L1fee

* sender

* to

* Failed & ReturnValue

* createdAcc & after

* remove MPTWitness

* txStorageTrace

* add FeeRecipient

* add StorageTrace

* fix FFI types

* better logger

* cargo fmt

* fix

* add build tags

* update Makefile

* fix library

* improve ld path

* correctly deal with circuit_capacity_checker returned result

* fix return value

* update cargo (ethereum#333)

* update cargo

* update

* update go

* refactor

* raname `circuits capacity checker` to `circuit capacity checker`

* some refactorings

* [Fix] storage proof generation in capacity checker (ethereum#348)

* make per-tx storage and deletion proof work

* format

* fix misplaced markdeletion

---------

Co-authored-by: HAOYUatHZ <haoyu@protonmail.com>

* docker (ethereum#363)

* update Dockerfile

* build: update go version to 1.19

* update

* fix

* fix

* try

* simplify

* revert go version

update l2geth Dockerfiles

* fix

* fix coinbase

* fix (ethereum#369)

* format

* Update version.go

* address comments

* Capacity refactor (ethereum#374)

* init

* id

* support multiple instances

* fix id

* fix conflicts

* refactor to use same codes (ethereum#379)

* re-init

* WIP

* WIP

* refactor

* go

* minor

* fix storage proof of l1gas price oracle

* move 1

* move 2

* move 3

* move 4

* move 5

move 5

* move 6

move 6

* move 7

* move 8

* move 9

* move 10

* clean up

clean up

---------

Co-authored-by: Ho Vei <noelwei@gmail.com>

* finish basic

* minor

* config capacity check in block_validator (ethereum#380)

* init

* done

ref

* fix tests

fix tests

fix tests

fix tests

* add more comments

* apply_block

* improve logs

* cargo fmt

* Capacity big refactor (ethereum#383)

* CreateTraceEnv

* WIP

* draft

more

fix

* for test

* fortet

* clean up

* add more comments

* goimports -local github.com/scroll-tech/go-ethereum -w .

* fix typos

* attempt 1

* attempt 2

* attempt 3

* gogogo

* clean up

* fix

* fix

* rename

* minor

* fix

* minor

* minor

* improve doc

* use dedicated `checkCircuitCapacity` flag (ethereum#394)

* refactor

* fix

* add lock

* [feat] capacity checking: upgrade libzkp (ethereum#395)

* upgrade

* upgrade libzkp

* write RowConsumption (ethereum#396)

* write RowConsumption

* name alignments

* revert some formatting

* add lock to CircuitCapacityChecker in BlockValidator

* remove mutex pointer

* improve github workflow

* improve

* store row consumption in mining (ethereum#397)

* prepare

* finish

* add more logs

* mark `ApplyBlock` as ready

* update libzkp (ethereum#401)

* fix

* Capacity detail (ethereum#402)

* fix(block-validation): consider skipping in ValidateL1Messages (ethereum#405)

* fix(block-validation): consider skipping in ValidateL1Messages

* fix(block): consider skipping in L1MessageCount

* fix l1 validation tests

* fix NumL1Messages

* fix impl.go return types

fix

* better error handling (ethereum#407)

* add

add

* add

* add

* add

* add

* cargo fmt

* add

* update

* add

* WIP

* minor

* gogogo

* gogogo

* fix

* fix

* fix

* cargo clippy

* improve

* improve

* creation lock (ethereum#408)

* creation lock

* update

* Debug log (ethereum#409)

* add more logs

* more

* more

* fix

* improve

* Update cmd/utils/flags.go

Co-authored-by: Péter Garamvölgyi <peter@scroll.io>

* refactor worker.commit()

* avoid re-calculate

* txpool ccc err handling (ethereum#411)

* more explicit error comments

* add more logs

* fix unnecessary commit

* add more logs

* fix `ineffassign`

* add more comments

* log id for `NewCircuitCapacityChecker` (ethereum#414)

add log to `NewCircuitCapacityChecker`

* Persist skip info for block where all L1 msgs are skipped (ethereum#415)

persist skip info for block where all L1 msgs are skipped

* Update version.go

---------

Co-authored-by: Ho Vei <noelwei@gmail.com>
Co-authored-by: Zhang Zhuo <mycinbrin@gmail.com>
Co-authored-by: Péter Garamvölgyi <peter@scroll.io>
marioevz pushed a commit to marioevz/go-ethereum that referenced this issue Feb 6, 2024
…#323)

* add switch to override the stride of the overlay conversion

* set a default stride of 10k
luanxu-mxc pushed a commit to MXCzkEVM/mxc-geth that referenced this issue Nov 21, 2024
…hing txpool content (ethereum#323)

* reduce the frequency of zlib compression when fetching txpool content

* fix go import order

* fix comment
s1na pushed a commit to s1na/go-ethereum that referenced this issue Dec 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants