EIP-4758 Implementation #24389
Closed
EIP-4758 Implementation #24389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
In this draft PR, fork ordering rules require |
|
Closing in favour of #25871 |
... not :) |
holiman
requested changes
Oct 14, 2022
jwasinger
force-pushed
the
selfdestruct-to-sendall
branch
from
259df37 to
1958991
Compare
jwasinger
force-pushed
the
selfdestruct-to-sendall
branch
from
1958991 to
ae00914
Compare
gumb0
reviewed
Jan 20, 2023
| instructionSet := newMergeInstructionSet() | ||
| instructionSet[SENDALL] = &operation{ | ||
| execute: opSendall, | ||
| dynamicGas: gasSelfdestructEIP3529, |
There was a problem hiding this comment.
I think you forgot to charge constant gas too
Suggested change
| dynamicGas: gasSelfdestructEIP3529, | |
| constantGas: params.SelfdestructGasEIP150, | |
| dynamicGas: gasSelfdestructEIP3529, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of the "nuclear" option for removing SELFDESTRUCT in a future hardfork:
At block
SendallForkBlock, the behavior ofSELFDESTRUCTchanges to only send the balance of the originating contract to the target recipient and no longer deletes the originating contract.