core/vm: implement EIP-3670: EOF - Code Validation #24090
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
commented
Dec 10, 2021
| @@ -40,6 +40,8 @@ type operation struct { | |||
|
|
|||
| // memorySize returns the memory size required for the operation | |||
| memorySize memorySizeFunc | |||
|
|
|||
| undefined bool | |||
There was a problem hiding this comment.
This is undefined rather than defined because this way it can be initialized only in one place (bottom of this file) only for undefined instructions (i.e. defined is default)
There was a problem hiding this comment.
Another idea to achieve this is to have a separate bitmap for defined opcodes and return it together with jump table, i.e.
type JumpTable struct {
operations [256]*operation
defined [32]byte
}
gumb0
force-pushed
the
eip-3670
branch
3 times, most recently
from
813795e to
d74609d
Compare
gumb0
force-pushed
the
eip-3670
branch
4 times, most recently
from
e632518 to
58401a8
Compare
gumb0
force-pushed
the
eip-3670
branch
2 times, most recently
from
f0330f1 to
b8549e9
Compare
gumb0
force-pushed
the
eip-3670
branch
3 times, most recently
from
2eae00d to
39418ee
Compare
gumb0
force-pushed
the
eip-3670
branch
2 times, most recently
from
229d9cd to
cb1d9b7
Compare
|
Rebased over #22958. |
gumb0
force-pushed
the
eip-3670
branch
3 times, most recently
from
04fd468 to
acd5ca1
Compare
It is required to distinguish INVALID in the jump table from undefined opcodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://eips.ethereum.org/EIPS/eip-3670
Requires #22958