Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core, params: implement EIP-3529 #22733

Merged
merged 3 commits into from
May 7, 2021
Merged

core, params: implement EIP-3529 #22733

merged 3 commits into from
May 7, 2021

Conversation

holiman
Copy link
Contributor

@holiman holiman commented Apr 25, 2021

This PR implements EIP 3529

Constant Value
FORK_BLOCK TBD
NEW_MAX_REFUND_QUOTIENT 5

For blocks where block.number >= FORK_BLOCK, the following changes apply.

  1. Remove the SELFDESTRUCT refund.
  2. Replace SSTORE_CLEARS_SCHEDULE with SSTORE_RESET_GAS + ACCESS_LIST_STORAGE_KEY_COST (4,800 gas as of EIP-2929 + EIP-2930)
  3. Reduce the max gas refunded after a transaction to gas_used // NEW_MAX_REFUND_QUOTIENT

@holiman holiman mentioned this pull request Apr 26, 2021
Closed
holiman
holiman commented May 6, 2021
View reviewed changes
core/state_transition.go Outdated
@@ -273,7 +274,13 @@ func (st *StateTransition) TransitionDb() (*ExecutionResult, error) {
st.state.SetNonce(msg.From(), st.state.GetNonce(sender.Address())+1)
ret, st.gas, vmerr = st.evm.Call(sender, st.to(), st.data, st.gas, st.value)
}
st.refundGas()
if !eip2539 {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be eip3529 not 2539

@holiman holiman added the london label May 6, 2021
@karalabe karalabe added this to the 1.10.4 milestone May 7, 2021
karalabe
karalabe reviewed May 7, 2021
View reviewed changes
Copy link
Member

@karalabe karalabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@karalabe karalabe merged commit a5669ae into ethereum:master May 7, 2021
atif-konasl pushed a commit to frozeman/pandora-execution-engine that referenced this pull request Oct 15, 2021
@holiman @karalabe @atif-konasl
core, params: implement EIP-3529 (ethereum#22733)
fb9a6fd 
* core, params: implement EIP-3529

* core/vm: add london instructionset

* core/vm: add method doc for EIP enabler

Co-authored-by: Péter Szilágyi <peterke@gmail.com>
@dustinxie dustinxie mentioned this pull request Mar 23, 2022
Merged
10 tasks
This was referenced Sep 23, 2022
Closed
Merged
@junnmm junnmm mentioned this pull request Feb 6, 2023
Merged
This was referenced Mar 15, 2023
Closed
Closed
@Mister-EA Mister-EA mentioned this pull request Mar 24, 2023
Closed
@trinhdn2 trinhdn2 mentioned this pull request Jun 28, 2023
Closed
14 tasks
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 22, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
60c9736
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 23, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
b9cac03
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 24, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
a32a0e1
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
9832c89
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 25, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
224c9e5
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
a36f26b
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
3ca88af
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Aug 26, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
34a08fa
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 2, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
703153c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 6, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
9f256bd
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
f48f39f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 9, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
ca66637
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
ac3f2cf
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 12, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
95ea171
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 19, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
f923a31
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 21, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
688e2b7
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
bdf36be
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 22, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
b02759f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
8c67a4f
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 26, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
4bac54c
gzliudan added a commit to gzliudan/XDPoSChain that referenced this pull request Sep 27, 2024
@gzliudan
core, params: implement EIP-3529 (ethereum#22733)
5eeba6e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karalabe karalabe karalabe left review comments

@geoknee geoknee geoknee left review comments

@rjl493456442 rjl493456442 Awaiting requested review from rjl493456442 rjl493456442 is a code owner

Assignees
No one assigned
Labels
london status:triage
Projects
None yet
Milestone
1.10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@holiman @karalabe @geoknee