Implement BEP-212 : Reduction of Refunds #1392
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 24, 2023 13:57
Mister-EA
requested review from
brilliant-lx,
bnb-tw,
emailtovamos,
MatusKysel and
unclezoro
|
Would it better to enable BEP-212 later, like the hard fork after Bonel, maybe the Lynn, so community would have more time to get prepared. |
MatusKysel
previously approved these changes
Mar 29, 2023
| initialStorage[common.HexToHash("02")] = common.HexToHash("02") | ||
|
|
||
| // Expected gas is intrinsic + 2*pushGas + cold load (due to legacy tx) + SstoreReset (a->b such that a,b!=0) - sstoreClearGasRefund | ||
| expectedGasUsage := params.TxGas + 2*vm.GasFastestStep + params.ColdSloadCostEIP2929 + (params.SstoreResetGasEIP2200 - params.ColdSloadCostEIP2929) - params.SstoreClearsScheduleRefundEIP3529 |
There was a problem hiding this comment.
Could you explain this a bit more?
There was a problem hiding this comment.
Essentially what happens is that running the bytecode you have gas costs for:
- intrinsic transaction gas
- the two
PUSHoperations - Modifying a storage variable
and you have get a refund for:
- Setting a storage variable to 0 from some other value (the refund is
params.SstoreClearsScheduleRefundEIP3529)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements BEP-212 . This is done by enabling EIP-3529 for BSC on the next hard fork block.
Concretely this BEP:
SELFDESTRUCT.SSTOREto 1/5th of the gas used in the transaction.SstoreClearsScheduleRefundfrom 15,000 to 4,800 .Rationale
Currently the code implementing EIP-3592 is present in the repository, but is not enabled.
Moreover, no tests were added in the pull request implementing it in go-ethereum : ethereum/go-ethereum#22733 . Those tests were added in the ethereum git submodules which BSC does not use. For this reason new tests for EIP-3529 are added in this PR.
Since EIP-3529 is built upon EIP-2929, this PR also enables EIP-2929. For this a new VM instructionset is defined with both EIPs enabled.
Changes
Notable changes:
params/config.go: config changes to include hard fork block.vm/jump_table.go: defining a new instructionset with EIP3529 and EIP2929 enabled.core/blockchain_eip3529_test.go: tests for the gas refunds when EIP3529 is enabled or disabled.