internal/ethapi: default to 0x00-account instead of local accounts for calls #20702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjl
changed the title
pull bot
pushed a commit
to scope-demo/go-ethereum
that referenced
this pull request
Feb 25, 2020
This makes eth_call and eth_estimateGas use the zero address as sender when the "from" parameter is not supplied. Co-authored-by: Felix Lange <fjl@twurst.com>
tonyredondo
pushed a commit
to scope-demo/go-ethereum
that referenced
this pull request
Feb 27, 2020
* internal/ethapi: default to zero address for calls (ethereum#20702) This makes eth_call and eth_estimateGas use the zero address as sender when the "from" parameter is not supplied. Co-authored-by: Felix Lange <fjl@twurst.com> * les: separate peer into clientPeer and serverPeer (ethereum#19991) * les: separate peer into clientPeer and serverPeer * les: address comments * mobile: add CallOpts.SetFrom (ethereum#20721) This was missing because I forgot to wrap it when bind.CallOpts.From as added. * crypto/bn256: fix import line (ethereum#20723) * p2p/discv5: fix test on go 1.14 (ethereum#20724) Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: gary rong <garyrong0905@gmail.com> Co-authored-by: Adam Schmideg <adamschmideg@users.noreply.github.com>
kjx98
pushed a commit
to kjx98/go-ethereum
that referenced
this pull request
Mar 17, 2020
This makes eth_call and eth_estimateGas use the zero address as sender when the "from" parameter is not supplied. Co-authored-by: Felix Lange <fjl@twurst.com>
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
This makes eth_call and eth_estimateGas use the zero address as sender when the "from" parameter is not supplied. Co-authored-by: Felix Lange <fjl@twurst.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #20685 by defaulting to nil-account.