les: separate peer into clientPeer and serverPeer #19991
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjl493456442
force-pushed
the
peer-separation
branch
2 times, most recently
from
6d9ab88
to
03feffd
Compare
|
@zsfelfoldi I think this big stuff is ready for review. If you have the plan to review something, please take a look. |
rjl493456442
force-pushed
the
peer-separation
branch
from
03feffd
to
3e29395
Compare
rjl493456442
force-pushed
the
peer-separation
branch
from
3e29395
to
f0f6dd3
Compare
rjl493456442
force-pushed
the
peer-separation
branch
from
f0f6dd3
to
a8e3f2f
Compare
rjl493456442
force-pushed
the
peer-separation
branch
from
a8e3f2f
to
8ac452f
Compare
rjl493456442
force-pushed
the
peer-separation
branch
from
8ac452f
to
843af02
Compare
zsfelfoldi
requested changes
Feb 23, 2020
rjl493456442
force-pushed
the
peer-separation
branch
from
843af02
to
15d3b0a
Compare
|
@zsfelfoldi Fixed, ptal again |
pull bot
pushed a commit
to scope-demo/go-ethereum
that referenced
this pull request
Feb 26, 2020
* les: separate peer into clientPeer and serverPeer * les: address comments
tonyredondo
pushed a commit
to scope-demo/go-ethereum
that referenced
this pull request
Feb 27, 2020
* internal/ethapi: default to zero address for calls (ethereum#20702) This makes eth_call and eth_estimateGas use the zero address as sender when the "from" parameter is not supplied. Co-authored-by: Felix Lange <fjl@twurst.com> * les: separate peer into clientPeer and serverPeer (ethereum#19991) * les: separate peer into clientPeer and serverPeer * les: address comments * mobile: add CallOpts.SetFrom (ethereum#20721) This was missing because I forgot to wrap it when bind.CallOpts.From as added. * crypto/bn256: fix import line (ethereum#20723) * p2p/discv5: fix test on go 1.14 (ethereum#20724) Co-authored-by: Martin Holst Swende <martin@swende.se> Co-authored-by: Felix Lange <fjl@twurst.com> Co-authored-by: gary rong <garyrong0905@gmail.com> Co-authored-by: Adam Schmideg <adamschmideg@users.noreply.github.com>
kjx98
pushed a commit
to kjx98/go-ethereum
that referenced
this pull request
Mar 17, 2020
* les: separate peer into clientPeer and serverPeer * les: address comments
7 tasks
enriquefynn
pushed a commit
to enriquefynn/go-ethereum
that referenced
this pull request
Mar 10, 2021
* les: separate peer into clientPeer and serverPeer * les: address comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second big refactor PR for les package.
In this PR, peers are separated into two types: serverPeer and clientPeer. The former refers to the peers of
light_client. The latter refers to the peers ofles_server.