Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmd, dashboard, p2p: send peer info to the dashboard #19397

Closed
wants to merge 1 commit into from
Closed

cmd, dashboard, p2p: send peer info to the dashboard #19397

wants to merge 1 commit into from

Conversation

kurkomisi
Copy link
Contributor

This PR contains:

  • change in the peer event feed logic, the handshake event is triggered after the protoHandshakeChecks and a peer instance is sent to the dashboard
  • fix of a data race between the network layer and the dashboard, moving the peer event subscription to dashboard.New
  • transmission of some information about the peers to the dashboard
  • visualization of the peer data
  • some UI improvements

@kurkomisi kurkomisi requested review from fjl and zsfelfoldi as code owners April 5, 2019 07:08
This was referenced Apr 15, 2019
Closed
Closed
@kurkomisi kurkomisi mentioned this pull request May 21, 2019
Closed
@kurkomisi
Copy link
Contributor Author

Superseded by #19606

@kurkomisi kurkomisi closed this May 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fjl fjl Awaiting requested review from fjl fjl is a code owner

@zsfelfoldi zsfelfoldi Awaiting requested review from zsfelfoldi zsfelfoldi is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kurkomisi