cmd, dashboard, p2p: patch metered peer event data race #19310
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nonononononono. You are leaking dashboard internals out into |
|
Aah, yes sure. The channels go down exactly that way, I don't know why I didn't see this... Thank you! I change it immediately. |
kurkomisi
force-pushed
the
dashboard-peer-feed-store
branch
from
d84c825 to
b36134a
Compare
|
Superseded by #19397 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a data race between the network layer and the dashboard, which can cause some lost peer events, therefore some peers might not appear on the dashboard.
This PR contains the registration of a subscription to the metered peer event feed in order to collect the initial events before the start of the dashboard service.